Pubdev 4995 #1640
Merged
Pubdev 4995 #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkurka
reviewed
Oct 16, 2017
| raised = False | ||
| agg = H2OAggregatorEstimator(model_id="aggregator") | ||
| try: | ||
| agg.train(training_frame=data, x="minairtemp", y="maxairtemp") |
There was a problem hiding this comment.
We should also test that the API provides correct results. Without that we cannot close PUBDEV-4995 (the jira is really about aggregator not being supported in Python).
michalkurka
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well obviously Aggregator uses schema v99 now, so fixed it manually to that version for now.
Maybe we could parse the schema version from REST and include it in bindings.
Also added simple test, which may be more sophisticated, like comparing rest_version used in python API to the one received from server..