Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: build gradle #161

Merged
merged 5 commits into from
Jul 12, 2024
Merged

refactor: build gradle #161

merged 5 commits into from
Jul 12, 2024

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jul 10, 2024

  • split large sdk/build.gradle to several dedicated scripts for size check and java generation

@CAMOBAP CAMOBAP requested a review from DSergiu July 10, 2024 21:08
@CAMOBAP CAMOBAP self-assigned this Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  51.7 KiB │  51.7 KiB │  0 B 
 manifest │     411 B │     411 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │     954 B │     954 B │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 131.3 KiB │ 131.3 KiB │  0 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 162 │ 162 │ 0 (+0 -0)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +338.14 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +368.10 +99
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -0.45 +97
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -11.06 +557
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +53.73 +1

@DSergiu DSergiu changed the title Refactor/build gradle refactor: build gradle Jul 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CAMOBAP CAMOBAP merged commit 6cd1223 into main Jul 12, 2024
12 checks passed
@CAMOBAP CAMOBAP deleted the refactor/build-gradle branch July 12, 2024 06:24
@CAMOBAP CAMOBAP restored the refactor/build-gradle branch July 12, 2024 06:24
@CAMOBAP CAMOBAP deleted the refactor/build-gradle branch July 12, 2024 06:24
CAMOBAP added a commit that referenced this pull request Jul 16, 2024
@CAMOBAP
ci: skip sonarqube step for PR from form #109 (#156)
73df5de 
* ci: skip sonarqube step for PR from form #109

* ci: use fresh AVD from benchmark tests (#157)

* refactor: build gradle (#161)

* chore: split big sdk/build.gradle to several applied gradle sripts

* chore: upload all outputs and reports on benchmark failure

* ci: move timeout restoriction to step level and reduce it to 20

* debug: enable artifact upload for success bench

* fix: ignore HCaptchaWebViewHelperTest.benchmarkWebViewLoad benchmark

* ci: skip sonarqube step for PR from form #109

* ci: migrate to own check-user-permission action

* fix: bad prior merge

* fix: add value to outputs of check-user-permission action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSergiu DSergiu DSergiu approved these changes

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAMOBAP @DSergiu