Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compose passive sitekey #165

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix: compose passive sitekey #165

merged 3 commits into from
Aug 21, 2024

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Aug 21, 2024

Fix for broken hideDialog=true for hcaptcha jetpack compose sdk

@CAMOBAP CAMOBAP requested a review from e271828- August 21, 2024 10:08
@CAMOBAP CAMOBAP self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────
      jar │  51.7 KiB │  51.7 KiB │  0 B 
 manifest │     411 B │     411 B │  0 B 
      res │  78.3 KiB │  78.3 KiB │  0 B 
    other │     954 B │     954 B │  0 B 
──────────┼───────────┼───────────┼──────
    total │ 131.3 KiB │ 131.3 KiB │  0 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  37 │  37 │ 0 (+0 -0) 
 methods │ 507 │ 507 │ 0 (+0 -0) 
  fields │ 162 │ 162 │ 0 (+0 -0)
AAR
 size │ diff │ path    
──────┼──────┼─────────
  0 B │  0 B │ (total)

Copy link

github-actions bot commented Aug 21, 2024

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +591.34 -7
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +675.55 +100
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +10.81 +96
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +42.53 +593
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +102.17 +1

@CAMOBAP CAMOBAP requested a review from DSergiu August 21, 2024 10:43
@DSergiu DSergiu changed the title Bugfix/compose passive sitekey fix: compose passive sitekey Aug 21, 2024
Copy link

sonarcloud bot commented Aug 21, 2024

@CAMOBAP CAMOBAP merged commit dab230c into main Aug 21, 2024
12 checks passed
@CAMOBAP CAMOBAP deleted the bugfix/compose-passive-sitekey branch August 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants