Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser-support): add target to esbuild options #19

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

faris-imi
Copy link
Contributor

@faris-imi faris-imi commented Jan 24, 2024

No description provided.

@faris-imi faris-imi self-assigned this Jan 24, 2024
@faris-imi faris-imi requested a review from a team as a code owner January 24, 2024 00:05
Copy link
Contributor

@brdlyptrs brdlyptrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See no issues with this. Does this solve the original issue you saw with some versions failed to load?

@faris-imi
Copy link
Contributor Author

See no issues with this. Does this solve the original issue you saw with some versions failed to load?

Yes, with this PR, browser support is extended to:

'chrome54',
'firefox50',
'safari11',

@@ -1,7 +1,7 @@
{
"name": "@hcaptcha/loader",
"description": "This is a JavaScript library to easily configure the loading of the hCaptcha JS client SDK with built-in error handling.",
"version": "1.1.2",
"version": "1.1.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, 1.2.0 at least?

@faris-imi faris-imi merged commit 537bc1d into main Jan 24, 2024
3 checks passed
@faris-imi faris-imi deleted the fix/target-browser branch January 24, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants