[corretto8] - Change download source #3461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MindNumbing <[email protected]>
stevendanna
reviewed
Sep 8, 2020
| @@ -7,7 +7,7 @@ pkg_description=('Corretto is a build of the Open Java Development Kit (OpenJDK) | |||
| pkg_license=("GPL-2.0-only") | |||
| pkg_upstream_url=https://aws.amazon.com/corretto/ | |||
| pkg_maintainer="The Habitat Maintainers <[email protected]>" | |||
| pkg_source="https://d2znqt9b1bc64u.cloudfront.net/amazon-corretto-${pkg_version}-linux-x64.tar.gz" | |||
| pkg_source="https://d3pxv6yz143wms.cloudfront.net/${pkg_version}/amazon-corretto-${pkg_version}-linux-x64.tar.gz" | |||
There was a problem hiding this comment.
Is there not a non-cloudfront URL we can use? Perhaps one of these?
https://docs.aws.amazon.com/corretto/latest/corretto-11-ug/downloads-list.html
If not, I think a comment on why we use this cloudfront URL directly might be good.
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
Signed-off-by: MindNumbing <[email protected]>
…ing/core-plans into change_corretto8_source
|
Now that #3450 has been approved and #3472 has been merged, these plans are no longer available in this repository. Please see Additional Plans for more information. Closing this PR, feel free to re-open at the new location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows build currently failing due to #3448
Signed-off-by: MindNumbing [email protected]