Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[corretto8, corretto, corretto11] Fix broken patchelf injection #3471

Closed
wants to merge 1 commit into from
Closed

[corretto8, corretto, corretto11] Fix broken patchelf injection #3471

wants to merge 1 commit into from

Conversation

gavindidrichsen
Copy link
Contributor

@gavindidrichsen gavindidrichsen commented Sep 7, 2020

The above mentioned corretto distributions have changed the file application file type from application/x-executable to application/x-pie-executable. This change in type impacted the existing plan: since a grep selection of files for patchelf injection was based on the old application type pattern, then the patchelf injection did not occur as expected. This PR fixes the grep and therefor issue #3448.

core/corretto after doing local build in studio now works:

[7][default:/src/corretto:0]# hab pkg exec core/corretto/11.0.8.10.1/20200907182859 -- java -version
openjdk version "11.0.8" 2020-07-14 LTS
OpenJDK Runtime Environment Corretto-11.0.8.10.1 (build 11.0.8+10-LTS)
OpenJDK 64-Bit Server VM Corretto-11.0.8.10.1 (build 11.0.8+10-LTS, mixed mode)
[8][default:/src/corretto:0]# 

Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this. If you have a minute, I think the commit message could use some work.

  1. Your summary doesn't fix on the first line
  2. It doesn't explain why this is the right fix. I'm assuming that file now returns something like x-pie-executable which is why the old grep didn't work. A sentence or two spelling out that reasoning would make this easier to review for correctness.

injection succeeds

Signed-off-by: Gavin Didrichsen <[email protected]>
@MindNumbing
Copy link
Contributor

MindNumbing commented Sep 16, 2020

Now that #3472 has been merged, these plans are no longer available in this repository.

Please see Additional Plans for more information.

Closing this PR, feel free to re-open at the new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants