registered project blueprint and created update project route #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good otherwise, good PR description with lots of context! we will wait for your other PRs and then it's probably good to merge it in |
* Initial project domain model * Reformatted code * Update Project Model 1. Implemented UUID 2. deleted an empty line 3. Ran black on the model.py again to ensure formatting consistency
celinehuang
reviewed
Nov 29, 2020
| @@ -49,4 +49,8 @@ def create_app(config_name): | |||
|
|
|||
| app.register_blueprint(note_blueprint, url_prefix="/note") | |||
|
|
|||
| from .project import project as project_blueprint | |||
| year = data.get("year") | ||
| name = data.get("name") | ||
| # should we change the name of the attribute to project_type instead | ||
| type = data.get("type") |
There was a problem hiding this comment.
I have no preference on whether to change it or not, although you could just do project_type = data.get("type") instead (<- not sure if this is what you mean) since that wouldn't affect the model. Up to you though, I personally think it'd be ok - @peterghrong thoughts?
There was a problem hiding this comment.
project_type would be better in my opinion, since there is also the contact_type, Idk how I'm only reading this now. Apologies !
* Added Donation domain model class Co-authored-by: aqghawa <[email protected]>
* Creating a general model for Contact Type * Running black locally for testing purposes. * Adding necessary changes for ContactType Domain Class.
* Added MuUser domain model class * Changed id and class names to match domain model * Removed Removed everything related to authentication, this includes imports, http_auth, and password properties. Added lazy=true. * Removed an extra comma * Black format * Removed password_hash Co-authored-by: aqghawa <[email protected]>
* Fix models.py to follow Python naming conventions * Oops remove more note association * Pluralize table name * Fix names to follow Python conventions * Small fixes
* Add project serializer * Remove pluralization
|
Added some units tests to make sure everything works. |
|
Closed as #85 was created to remove git issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've registered the 'project' blueprint and created a route to update a project based on the specified uuid.
The defined function is subject to change, as it is dependent on how the 'Photo' and 'Project' models are defined and how photos of a project should be updated.
Details
Test Plan
I plan to write unit tests for this route after dependent issues are closed and corresponding pull requests are merged.
Related Issues