-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registered project blueprint and created update project route #40
Conversation
looks good otherwise, good PR description with lots of context! we will wait for your other PRs and then it's probably good to merge it in |
* Initial project domain model * Reformatted code * Update Project Model 1. Implemented UUID 2. deleted an empty line 3. Ran black on the model.py again to ensure formatting consistency
@@ -49,4 +49,8 @@ def create_app(config_name): | |||
|
|||
app.register_blueprint(note_blueprint, url_prefix="/note") | |||
|
|||
from .project import project as project_blueprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good catch lol my bad
year = data.get("year") | ||
name = data.get("name") | ||
# should we change the name of the attribute to project_type instead | ||
type = data.get("type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no preference on whether to change it or not, although you could just do project_type = data.get("type")
instead (<- not sure if this is what you mean) since that wouldn't affect the model. Up to you though, I personally think it'd be ok - @peterghrong thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project_type would be better in my opinion, since there is also the contact_type, Idk how I'm only reading this now. Apologies !
* Added Donation domain model class Co-authored-by: aqghawa <[email protected]>
* Creating a general model for Contact Type * Running black locally for testing purposes. * Adding necessary changes for ContactType Domain Class.
* Added MuUser domain model class * Changed id and class names to match domain model * Removed Removed everything related to authentication, this includes imports, http_auth, and password properties. Added lazy=true. * Removed an extra comma * Black format * Removed password_hash Co-authored-by: aqghawa <[email protected]>
* Fix models.py to follow Python naming conventions * Oops remove more note association * Pluralize table name * Fix names to follow Python conventions * Small fixes
* Add project serializer * Remove pluralization
Added some units tests to make sure everything works. |
Closed as #85 was created to remove git issues |
Summary
I've registered the 'project' blueprint and created a route to update a project based on the specified uuid.
The defined function is subject to change, as it is dependent on how the 'Photo' and 'Project' models are defined and how photos of a project should be updated.
Details
Test Plan
I plan to write unit tests for this route after dependent issues are closed and corresponding pull requests are merged.
Related Issues