-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "USTree-Hub" board. #1426
base: main
Are you sure you want to change the base?
Add "USTree-Hub" board. #1426
Conversation
Hi, I'm Orpheus Leap! Here to help you review your PR.
projects/US-Tree Hub: Required files
You can view a render of your board over on gerber.zip/2d! Happy OnBoarding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi so good news, your PCB generally looks good and meets all limitations, but it does not exactly meet hacky-holidays theme criteria's, the general art style is amazing, but since it effectively the usb hub tutorial recreated we would really appreciate if you could maybe incorporate some more aspects like LEDs or similar into your design!
This is effectively the same as #1428, with thus the same issue!
There is actually an LED at the tip of the Christmas tree. |
I mean, if that's all it takes, I can simply add more LEDs on the branches of the tree... |
Okay, I've got the new board! How do I change the files in this pull request? |
Help! I can't find out how to update the files! |
The files should be fixed now! |
I added more LEDs (now there are three), and a switch to turn them on and off, so that they don't always use power! |
9fe2aa6
to
05de19a
Compare
Whoops |
Alright, two LEDs have been added. Researching ways on how to turn them on when a port is being used. |
Fixed the switch which didn't show up in the 3D-view for some reason. |
Can I... at least get some explanation? Please? |
Or a suggestion as to what I should fix? |
All good! Just slow to respond. Let me take a look and well get this approved! |
Yay!! Thank you! :) |
Submission Checklist:
#electronics
channel on Slackonboard/projects
TEMPLATE.md
asREADME.md
inside your project foldergerber.zip
andschematic.pdf
inside your project foldersrc
and uploaded design filescart.png
with all costs includedbom.csv
(Bill of Materials) file with the appropriate JLCPCB/LCSC Part numbers in the/src
directorypositions.csv
file in the/src
directoryFootnotes
Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials. ↩
OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack! ↩
Hacky Holidays is a limited-time PCB event, design a holiday-themed PCB this Winter, and get it shipped. ↩