Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Catover #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added Catover #137

wants to merge 3 commits into from

Conversation

bigloosegoose
Copy link

BrowserBuddy Extension Submission

Project Details

  1. What is the name of your project?
    Catover

  2. How many hours did you spend developing this?
    6.5 hours

  3. What problem does your extension solve, or what makes it unique?
    It takes away the boring ads and images and brings in positive cats!

  4. How many people have tested your extension?
    6 people

  5. Does your extension work in both Chrome and Firefox?
    (Your extension must be compatible with both browsers)
    yes


Additional Comments

(Feel free to provide any additional context or notes here)

Copy link

vercel bot commented Feb 17, 2025

@bigloosegoose is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.
Already i like that it works.
Also a couple ideas to improve this extension

  • It'd be nice to see stats as to how many ads were blocked on the page.
  • I think I'd like to see if which cat image is replacing an ad and which is not.
  • You could add surprise mode. Rare cats showing on rare occassions 👀

"strict_min_version": "42.0"
}
},
"manifest_version": 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use manifest version 3

Comment on lines 50 to 65
"*://*.adzerk.org/*",
"*://*.adzerk.us/*",
"*://*.adzerk.xyz/*",
"*://*.adzerk.biz/*",
"*://*.adzerk.co/*",
"*://*.adzerk.info/*",
"*://*.adzerk.io/*",
"*://*.adzerk.me/*",
"*://*.adzerk.mobi/*",
"*://*.adzerk.name/*",
"*://*.adzerk.pro/*",
"*://*.adzerk.site/*",
"*://*.adzerk.space/*",
"*://*.adzerk.tech/*",
"*://*.adzerk.tv/*",
"*://*.adzerk.website/*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you not make a single regex that matches all of these?

@JosiasAurel
Copy link
Collaborator

Also here's something very funny. For some reason after reloading this review page with your extension enabled it now shows cats all over my screen. Even my profile picture has been replaced with a cat image

image

@JosiasAurel
Copy link
Collaborator

Please reach out to me on Slack or respond to a thread referencing your extension in the #browser-buddy channel.

@bigloosegoose
Copy link
Author

Ok so made a UI, Made the icons for extension, Made the surprise feature, added purple border to all cat images to know that they are replaced

@bigloosegoose
Copy link
Author

unfortunately i couldn't make it manifest v3 as manifest v3 doesnt support adblockers

Copy link
Collaborator

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension still replaces images it's not supposed to replace with cat images. please fix this
SCR-20250219-qiyd

@bigloosegoose
Copy link
Author

Oh, to be honest that is deliberate

@bigloosegoose
Copy link
Author

you wanted it to just replace the ads?

@JosiasAurel
Copy link
Collaborator

you wanted it to just replace the ads?

yes! i don't want it to replace images that are important on a website i'm browsing on

@bigloosegoose
Copy link
Author

Thats why I added toggles in this update but ok I will make it replace just the ads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants