Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nl.hackclub.com #1251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding nl.hackclub.com #1251

wants to merge 2 commits into from

Conversation

Kipp-ie
Copy link

@Kipp-ie Kipp-ie commented Aug 20, 2024

Adding nl.hackclub.com

Description

Provide a description here of the changes, and if adding a subdomain provide a rationale & what it will be used for.
I made the global website in dutch. https://github.com/Kipp-ie/global

@Kipp-ie Kipp-ie requested review from a team as code owners August 20, 2024 10:21
@Muirrum
Copy link
Member

Muirrum commented Aug 20, 2024

Holding on hackclub/global#114

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, this isn't in alphabetical order & won't deploy! Please update so we can merge

Comment on lines +2885 to +2889

replit-takeout:
- ttl: 600
type: CNAME
value: cname.vercel-dns.com.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this addtl domain from the PR

@Muirrum
Copy link
Member

Muirrum commented Sep 26, 2024

hackclub/global#114 merged, @Kipp-ie please resolve review comments so this can be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants