Separate between games saved on frontend, games saved on backend and games shared #2469
+249
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve yet, except for development and cosmin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grymmy
reviewed
Oct 22, 2024
| <div class="title-container"> | ||
| <h3>{game.name || 'Untitled'}</h3> | ||
| <div class="icon-container"> | ||
| {game.isRoomOpen && |
There was a problem hiding this comment.
Can you add a picture in the main description of what this popup looks like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with the changes from #2414, which has not been approved at the time of writing this, but I needed those changes for this
Adds icons to games that have been shared/saved in the backend. A game that was saved on the backend can't be moved to the frontend saving strat. When a game upgrades to the backend saving(for example the users goes to /beta/ or the user gets upgraded to a beta user), the game is duplicated and a new copy which is now using the backend saving strat is opened. When a room is shared it doesn't make a copy of it before(should it?).
Reminder for self to update the saving server when this gets merged to only save games that have the isSavedOnBackend active.
fixes #2425