New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ignore list and fixed call to Task Manager JXA #4

Open

lars30 wants to merge 2 commits into hackerdude:master from lars30:master

lars30 commented Aug 11, 2015

Moving jira_to_jxa_app.rb into a subdirectory was causing the call to the task manager to fail with this message.

Error - No such file or directory - /Users/xxx/xxx/jiratotaskmanagers/lib/task_sources/jira/task_destinations/add_to_omnifocus.jxa

Adding '../../' fixed it.

Two other improvements I didn't make but would consider:

There may be a way to set the file location to the project root (so you can move it again without breaking the call to the task manager specific JXA). I'm not sure how to do this one.
Looking at this commit I'd probably want to change the variable name from 'things_jxa' to 'taskmanager_jxa' to make it clearer. I'm using omnifocus and that variable name gave me pause. If you'd like I can clean that up and do give you another pull request.

The .gitignore addition was just for the rvm dotfiles I used.

lars30 added 2 commits

August 10, 2015 21:56


          Update ignore list and fixed call to Task Manager JXA

2eff6d2


          Cleaned up references to things and omnifocus

22eed54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet