Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reuse random filename in filesystem image provider #1867

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented May 27, 2024

No description provided.

@Yukaii Yukaii added this to the 2.5.4 milestone Jun 5, 2024
@Yukaii Yukaii force-pushed the refactor/reuse-random-filename branch from 8d81cc6 to c5e2452 Compare June 5, 2024 06:44
@@ -47,7 +29,7 @@ exports.uploadImage = function (imagePath, callback) {

let filename = path.basename(imagePath)
try {
filename = pickFilename(path.basename(imagePath))
filename = randomFilename()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filename will no longer with file extension (.png), we should modify pickFilename function and only use randomFilename their without default filename.

@Yukaii Yukaii force-pushed the refactor/reuse-random-filename branch from c5e2452 to 12ed4f5 Compare June 5, 2024 07:08
@Yukaii Yukaii force-pushed the refactor/reuse-random-filename branch from 0dcb1a9 to 5eb3591 Compare June 5, 2024 07:25
@Yukaii Yukaii merged commit a0c82d3 into develop Jun 5, 2024
6 checks passed
@Yukaii Yukaii deleted the refactor/reuse-random-filename branch June 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants