more principled generic printer #533
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 11, 2024
W95Psp
force-pushed
the
rust-generic-printer
branch
from
26b440d
to
ae92eb4
Compare
W95Psp
force-pushed
the
rust-generic-printer
branch
from
ae92eb4
to
53b10c1
Compare
W95Psp
changed the title
W95Psp
force-pushed
the
rust-generic-printer
branch
from
53b10c1
to
0759a76
Compare
|
I updated this PR in a way the current generic printer and the new one cohabit. |
W95Psp
added
the
waiting-on-reviewer
franziskuskiefer
requested changes
Aug 12, 2024
cli/driver/src/exporter.rs
Outdated
| )) | ||
| }) | ||
| }); |
There was a problem hiding this comment.
As usual, some comments on what the new code is doing would be nice.
| @@ -0,0 +1,92 @@ | |||
| open! Prelude | |||
There was a problem hiding this comment.
Not sure if the name is the best ....
But aside from that, we need a design of this. Please add a design document (markdown, mermaind, whatever) that describes how this printer works and how it can be used.
And then document the code (with how it's implementing the design).
engine/profile.dump
Outdated
franziskuskiefer
removed
the
waiting-on-reviewer
W95Psp
force-pushed
the
rust-generic-printer
branch
from
d4c61fa
to
c10e43f
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring more principled/clean generic printer after chatting about the PV backend in Paris with Jonas.
Porting the PV printer should be easy, but that's a bit out of scope, I'm trying to play with the generic printer to converge to something nicer.
This generic printer supports fully source maps v3: any backend using the genric printer gets that for free.
The result is something like that or the fact a user can click in VSCode in some region of the extracted code and be directed to the Rust source.
Fixes #404