Engine: F*: fix #677 by always extracting implicit types #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
added a commit
to cryspen/libcrux
that referenced
this pull request
May 16, 2024
W95Psp
added a commit
to cryspen/libcrux
that referenced
this pull request
May 16, 2024
W95Psp
added a commit
to cryspen/libcrux
that referenced
this pull request
May 16, 2024
W95Psp
force-pushed
the
fix-667-explicits-types
branch
from
2fb251e
to
59ea525
Compare
franziskuskiefer
added a commit
to cryspen/libcrux
that referenced
this pull request
May 17, 2024
Regenerate patches following PR hacspec/hax#679
franziskuskiefer
approved these changes
May 17, 2024
Since we are now printing types explicitely, the F* library has no more freedom in term of implicits. For example, operations on vectors always take two implicits: the type of the items held by the vector, but also the type of the allocator. In F*, we don't care about the allocator, thus, we model any allocator with unit. In this setting, taking an implicit allocator each time we take a vector is useless in F*. But now, the extraction gives (as an implicit) the allocator, so we need to expect an allocator.
W95Psp
force-pushed
the
fix-667-explicits-types
branch
from
00e9cd8
to
ecc3a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #677, which describes the problem in more lengths.
This will break heavily Kyber, so I will push a companion PR on libcrux.
Fixes #677