Add infos impl #827
Merged
Add infos impl #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
add-infos-impl
branch
3 times, most recently
from
6cdd34f
to
6fb46a0
Compare
This commit: - renames `impl_expr` to `impl_expr_kind`; - adds a type `impl_expr` that consists of an `impl_expr_kind` and of a `trait_goal`. This change makes the "type" of an `impl_expr` available at any point. The "type" of an `impl_expr` is called a `trait_goal`. It is useful for performing trait-goal-based transformations.
W95Psp
force-pushed
the
add-infos-impl
branch
from
6fb46a0
to
6e94d30
Compare
W95Psp
force-pushed
the
add-infos-impl
branch
from
f42914b
to
59e14e2
Compare
franziskuskiefer
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had leftover work while working on iterators.
Those were required for iterators at the time, and are good generally.
This PR: