Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): when we generate a file that exists and has the same content, skip writing #849

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Aug 13, 2024

This PR:

  • prints relative paths instead of absolute ones in hax note messages
  • write files only when a file doesn't exists or has a different content as what we were about to write
  • prints the notice message hax: unchanged file <path> instead of hax: wrote file <path> in those cases

This is useful not to invalidate checked files in caches while typechecking F*

@W95Psp W95Psp added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit ff14107 Aug 14, 2024
13 checks passed
@W95Psp W95Psp deleted the write-file-only-if-changed branch August 14, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants