Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got windows installer to work #48

Open
wants to merge 9 commits into
base: construct
Choose a base branch
from

Conversation

thawn
Copy link

@thawn thawn commented Jan 15, 2024

The windows installer created by constructor installer\Win works now.

I had to create a workaround for the start menu entries, because I could not get "napari-menu" to play nicely with constructor (possibly because of #49).

Therefore, I created my own shortcut.json and installed that via a post-install.bat script.

The clean solution would be to create our own conda package (e.g. devbio-napari-shortcut) that installs devbio-napari_shortcut.json and the .ico file into %PREFIX%\Menu. That would then work the same way as napari-menu (but currently only for windows).

thawn added 4 commits January 15, 2024 17:08
used a hacky workaround for not having a package that provides the json file for the menu entry (like napari-menu)
@thawn
Copy link
Author

thawn commented Jan 15, 2024

here is the windows installer for download feel free to test it ;-)

@thawn
Copy link
Author

thawn commented Feb 9, 2024

Currently, I added some packages with restrictive licenses (e.g. pyqt) so that it runs out of the box. As discussed offline with @haesleinhuepf , one way to deal with this would be to make two installers, one with a restrictive license that comes with everything, and one with a permissive license that requires additional work by the user (or at least requires the user to check a box in the installer that runs a post-install script which installs the missing packages)

@zoccoler
Copy link

Hi @thawn ,

@stefanhahmann and I just tested it. The installation works, but it does not open (it opens a black console screen and after a few moments closes itself).
We think this naparia-script.py is missing (specified in the shortcut.json file), we could not find it anywhere in your fork (under "construct" branch at least).

@thawn
Copy link
Author

thawn commented Feb 29, 2024

@zoccoler @stefanhahmann thanks a lot for testing! I remember that I had the same issue at some point. I will look into it. Unfortunately, I don't have access to the windows machine where I got it to work at the moment. Let's have a look at it together in the afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants