Fix fscheck3 replay #515
Merged
Fix fscheck3 replay #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farlee2121
reviewed
Jan 6, 2025
Expecto.FsCheck/FsCheck.fs
Outdated
| @@ -71,7 +71,7 @@ module ExpectoFsCheck = | |||
| (String.concat " " data.Labels) | |||
|
|
|||
| let focus = | |||
| sprintf "Focus on error:\n\t%s (%A, %A) \"%s\"" methodName (uint64 std) (uint64 gen) name | |||
| sprintf "Focus on error:\n\t%s (%A, %A, 0) \"%s\"" methodName (uint64 std) (uint64 gen) name | |||
There was a problem hiding this comment.
What is the motivation for always printing zero here?
There was a problem hiding this comment.
This is so the user can copy and paste. The FsCheck 2 module will just ignore the third value
farlee2121
reviewed
Jan 6, 2025
Expecto/Model.fs
Outdated
| @@ -16,7 +16,7 @@ type FsCheckConfig = | |||
| /// The size to use for the last test, when all the tests are passing. The size increases linearly between Start- and EndSize. | |||
| endSize: int | |||
| /// If set, the seed to use to start testing. Allows reproduction of previous runs. | |||
| replay: (uint64 * uint64) option | |||
| replay: (uint64 * uint64 * int) option | |||
There was a problem hiding this comment.
The FsCheck API exposes size as an option. Is there a reason to require it here?
Also, we should probably update the help text to mention size
There was a problem hiding this comment.
Hmm I suppose not. I'll update to use an option, and update the fscheck2 stuff to use None
|
Thanks for splitting these up! This looks pretty good, I just had two questions that I left as comments. |
To allow more flexibility and match fscheck's type
|
Looks great. I'll get a preview package released soon. |
|
The alpha4 package is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the replay config to use the size parameter so fscheck 3 will skip directly to the failing case. Also updates test output to show the "final seed" which will directly run the failing case when used, instead of the "original seed"
Separated out from #511