-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in feature/hafs.v2.0.1 back to develop #299
Open
BinLiu-NOAA
wants to merge
53
commits into
develop
Choose a base branch
from
feature/hafs.v2.0.1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07/03/2024 (From @BijuThomas-NAA and @BinLiu-NOAA)
…tbl_new after the latest HAFS submodule syncing.
ush/hafs_filter_topo.sh, and ush/hafs_make_orog.sh. These updates are needed with the latest hafs_utils.fd sync. Also, the filter_topo and make_orog_gsl steps are substantialy speeded up through OMP threading.
…r.fd Update scripts/exhafs_enkf_hx.sh
gsi module on WCOSS2.
HAFS.v2.0.1, due to issues associated with the new updated restart file (sfc_data) with the latest UFS_UTILS chgres_cube updates. This is a temporary solution. The longer term solution is to update hafs_datool, VI, and GSI/DA so that they can work with the update restart files. * Update parm/mom6/regional/hafs_mom6.input.IN needed for MOM6 update. * Update scripts/exhafs_analysis.sh to link a new crtm fix file.
…cale-aware Tiedtke for HAFS
…dvars.conf, hafs.conf to improve the SLP and short range forecast. In convert_axi_xy.f90, the threshold for shallow composite vortex is changed from p_obs.lt.91510 (HAFS vortex SLP) to vslp.lt.92010 (TCVitals SLP)
@lisa-bengtsson's change to improve convection/radiation interaction.
Add parm/mom6/regional_hafs.v2.0.1a and parm/mom6/regional_hafs.v2.0.1b.
update parm/forecast/globnest/input*.nml.tmp according to its regional counterpart.
…ability enabled. * Update parm/ww3/regional/ww3_grid_?.inp by adding &OUTS USSP =1, IUSSP = 3, STK_WN = 0.04, 0.110, 0.3305 / * Update parm/mom6/regional_hafs.v2.0.1a/hafs_mom6.input.IN with USE_WAVES = True
also set the moving nest d02 increments along the domain boundaries (within 10 grid points) as zeros. (From @XuLu-NOAA and @BinLiu-NOAA)
…s from Hyun-Sook Kim (AOML).
Update parm/hafs.v2.0.1a.conf with lim_fac=2.7
between spack-stack and conda
…oid module conflicts
…oid module conflicts
- Updating run.ver for hafs and RTOFS versions. - Update scripts/exhafs_obs_prep.sh, which properly handles tempdrop obs processing errors/warnings.
BinLiu-NOAA
requested review from
ZhanZhang-NOAA,
KathrynNewman and
panll
as code owners
November 9, 2024 17:26
BinLiu-NOAA
added
Ready for Review
The PR is considered complete by the author(s)
Ready for RTs
The PR is ready to conduct Regression Tests
RTs Running on WCOSS2
Regression Tests are running on WCOSS2
labels
Nov 9, 2024
BinLiu-NOAA
requested review from
LinZhu-NOAA,
JunghoonShin-NOAA,
nriveratorres-NOAA,
ulmononian,
wramstrom and
ChuankaiWang-NOAA
November 14, 2024 15:52
@JunghoonShin-NOAA, @nriveratorres-NOAA, @LinZhu-NOAA, @ChuankaiWang-NOAA, could you please help to cover the regression tests for this PR on the following platforms, respectively? Thanks! |
BinLiu-NOAA
removed
the
RTs Running on WCOSS2
Regression Tests are running on WCOSS2
label
Nov 14, 2024
Regression tests on WCOSS2 have already passed successfully without issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Ready for Review
The PR is considered complete by the author(s)
Ready for RTs
The PR is ready to conduct Regression Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bring in the HAFSv2.0.1 development and configurations used by 2024 HFIP real-time parallel experiments back to HAFS develop branch. More details/configurations for 2024 HFIP HAFSv2.0.1A and B real-time parallel experiments can be found below.
Issues addressed (optional)
If this PR addresses one or more issues, please provide link(s) to the issue(s) here.
Contributors (optional)
If others worked on this PR besides the author, please include their user names here (using @Mention if possible).
EMC hurricane project team with lots of collaborators from the UFS Hurricane Application Team.
Tests conducted
What testing has been conducted on the PR thus far? Describe the nature of any scientific or technical tests, including relevant details about the configuration(s) (e.g., cold versus warm start, number of cycles, forecast length, whether data assimilation was performed, etc). What platform(s) were used for testing?
Technical, retrospective, and real-time parallel testing were conducted.
Application-level regression test status
Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.