fix: lint for go1.22.x

hakadoriya · Mar 24, 2024 · f3797d9 · f3797d9
1 parent 482bdf9
commit f3797d9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 11 deletions.
diff --git a/pkg/ddl/cockroachdb/lexar_test.go b/pkg/ddl/cockroachdb/lexar_test.go
@@ -78,8 +78,6 @@ func Test_lookupIdent(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -176,7 +174,6 @@ func TestLex(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -242,7 +239,6 @@ func TestLexer_NextToken(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/pkg/ddl/cockroachdb/parser_test.go b/pkg/ddl/cockroachdb/parser_test.go
@@ -135,8 +135,6 @@ CREATE TABLE IF NOT EXISTS complex_defaults (
 	}{}
 
 	for _, tt := range successTests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			// t.Parallel()
 
@@ -437,8 +435,6 @@ CREATE TABLE IF NOT EXISTS complex_defaults (
 	}
 
 	for _, tt := range failureTests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

diff --git a/pkg/ddl/internal/util.go b/pkg/ddl/internal/util.go
@@ -14,7 +14,7 @@ func GoString(v interface{}) string {
 
 	val := reflect.ValueOf(v)
 	elems := make([]string, typ.NumField())
-	for i := 0; typ.NumField() > i; i++ {
+	for i := range typ.NumField() {
 		elems[i] = fmt.Sprintf("%s:%#v", typ.Field(i).Name, val.Field(i))
 	}
 	return fmt.Sprintf("&%s{%s}", typ, strings.Join(elems, ", "))

diff --git a/pkg/ddl/mysql/lexar_test.go b/pkg/ddl/mysql/lexar_test.go
@@ -81,8 +81,6 @@ func Test_lookupIdent(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()