Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the schema part in the INDEX DDL for postgres and cockroachdb as it was incorrect AND Support CockroachDB FLOAT4 FLOAT8 #85

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

ginokent
Copy link
Contributor

Ticket / Issue Number

Note

Please fill in the ticket or issue number.

Example:

#3

What's changed

Note

Please explain what changes this pull request will make.

Example:

  • Added functionality to perform 'bar' on 'foo'.

Check List

  • Assign labels
  • Add appropriate test cases

Remark

Note

Please provide additional remarks if necessary.

@ginokent ginokent changed the title fix: Fix the schema part in the INDEX DDL for postgres and cockroachdb as it was incorrect fix: Fix the schema part in the INDEX DDL for postgres and cockroachdb as it was incorrect AND Support CockroachDB FLOAT4 FLOAT8 Jul 20, 2024
@github-actions github-actions bot added the fix A bug fix label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (be78ae9) to head (96aafd1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   92.69%   92.74%   +0.04%     
==========================================
  Files          84       84              
  Lines        7130     7122       -8     
==========================================
- Hits         6609     6605       -4     
+ Misses        501      499       -2     
+ Partials       20       18       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kunitsudev kunitsudev force-pushed the fix-cockroachdb-float4-float8 branch from 31566ed to a1185c4 Compare July 20, 2024 20:17
@ginokent ginokent marked this pull request as ready for review July 20, 2024 20:17
@ginokent ginokent requested a review from a team as a code owner July 20, 2024 20:17
@ginokent ginokent force-pushed the fix-cockroachdb-float4-float8 branch from a1185c4 to 96aafd1 Compare July 20, 2024 20:24
@ginokent ginokent enabled auto-merge July 20, 2024 20:25
@ginokent ginokent merged commit cac7117 into main Jul 20, 2024
11 checks passed
@ginokent ginokent deleted the fix-cockroachdb-float4-float8 branch July 20, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants