Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stayOpen and stayClose API #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kennethpdev
Copy link

As the name says, meny will stay in always open state or always close
state. can revert state by using stayOpen(false) or stayClose(false).

As the name says, meny will stay in always open state or always close
state.
We can revert state by using stayOpen(false) or stayClose(false)
@hakimel
Copy link
Owner

hakimel commented Feb 17, 2015

I tested this but was expecting those methods to also actually open and close the menu. So calling stayOpen opens the menu and keeps it open, where stayClose closes the menu and keeps it closed.

Maybe I'm misunderstanding how this is intended to be used – can you describe the use case?

Two other things:

  • stayClose should be renamed to stayClosed
  • We'll need new variable names for _stayOpen and _stayClose – no other variables in the file use underscore prefixing so these shouldn't either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants