HAL-1945: fix notification badge visibility

hal · Nov 23, 2023 · 0a416ae · 0a416ae
1 parent d96c947
commit 0a416ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/app/src/main/java/org/jboss/hal/client/skeleton/HeaderView.java b/app/src/main/java/org/jboss/hal/client/skeleton/HeaderView.java
@@ -178,7 +178,9 @@ public HeaderView(Environment environment, Places places, AccessControl ac, Reso
                                                 .add(span()
                                                         .css(fontAwesome("bell"))
                                                         .style("padding-right: 0"))
-                                                .add(badgeIcon = span().css(badge).id(Ids.BADEGE_ICON).element())
+                                                .add(badgeIcon = span().css(badge).id(Ids.BADGE_ICON)
+                                                        .textContent(" ") // badge content can't be empty
+                                                        .element())
                                                 .element()))
                                 .add(li().css(dropdown, hidden).id(Ids.HEADER_EXTENSIONS_DROPDOWN)
                                         .add(a().css(clickable, dropdownToggle)

diff --git a/resources/src/main/java/org/jboss/hal/resources/Ids.java b/resources/src/main/java/org/jboss/hal/resources/Ids.java
@@ -55,7 +55,7 @@ public interface Ids {
     String ASSIGNMENT_EXCLUDE = "assignement-exclude";
     String ASSIGNMENT_INCLUDE = "assignement-include";
     String ATTRIBUTES = "attributes";
-    String BADEGE_ICON = "badge-icon";
+    String BADGE_ICON = "badge-icon";
     String BOOT_ERRORS_ADDRESS_COLUMN = "boot-errors-address-column";
     String BOOT_ERRORS_EMPTY = "boot-errors-empty";
     String BOOT_ERRORS_FORM = "boot-errors-form";