ci: use AWS CLI v2 #1307
Merged
ci: use AWS CLI v2 #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AWS CLI v2 as v1 does not seem to be supported anymore on Ubuntu 24.04 (see also [this issue comment](unfor19/install-aws-cli-action#31 (comment)).
|
This PR cannot be merged yet because a required label is missing: |
|
hale studio builds for this pull request: Build triggered for commit d77b09d. |
Mainly because the original functionality was implemented using version 1 and when migrating to GitHub actions I retained that and did not invest the time to check if it works with version 2 ore if there may be changes required.
Not that I'm aware of. Maybe checking if the commands used still should work with version 2? |
stempler
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AWS CLI v2 as v1 does not seem to be supported anymore on Ubuntu 24.04 (see also this issue comment.
@stempler Do you remember why v1 is used here explicitly? And is there a good way of testing a change like this without merging it to
masterfirst?