Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce lerna #193

Closed
wants to merge 13 commits into from
Closed

Introduce lerna #193

wants to merge 13 commits into from

Conversation

halfzebra
Copy link
Owner

@halfzebra halfzebra commented Oct 19, 2017

This is the first PR focused on splitting CEA into separate packages #183

As a first step I'm moving create-elm-app into packages.

@fobos
Copy link
Contributor

fobos commented Oct 20, 2017

Will review it later today

@halfzebra
Copy link
Owner Author

@fobos please let me know if you will have time to check this one out!

@fobos
Copy link
Contributor

fobos commented Oct 27, 2017

Am I right that you going to split CEA into separate packages containing simple command for CEA?
Can you describe what are you going to do with it next?

@halfzebra
Copy link
Owner Author

halfzebra commented Oct 27, 2017

@fobos thanks, that's a very good question 🙂

Originally I wanted to move ./scripts/utils into a separate npm package, so ejecting is similar to Create React App, but there's more to it. I have considered rewriting the error overlay in Elm.

I also want to have a reusable elm-app-scripts, which will contain the scripts for running the app, which will enable people to customize Create Elm App with less effort.

Having everything isolated, just as in CRA, there might be an opportunity to create a CRA-compatible elm-app-scripts, so it's possible to use Elm setup with Create React App(not a very big benefit, but might be a low hanging fruit)

I wanted to keep the semantic release setup, but also add lerna to manage a multi-package repo.

Copy link
Contributor

@fobos fobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having reusable script is good idea.

@fobos
Copy link
Contributor

fobos commented Oct 28, 2017

@halfzebra thanks for explanation.

@halfzebra
Copy link
Owner Author

halfzebra commented Jan 11, 2018

This is on hold due to atlassian/lerna-semantic-release#89

@halfzebra
Copy link
Owner Author

Closing this in favor of adopting https://github.com/Updater/semantic-release-monorepo

@halfzebra halfzebra closed this Aug 7, 2018
@halfzebra halfzebra mentioned this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants