Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for top-of-tree LLVM changes #7663

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

steven-johnson
Copy link
Contributor

No description provided.

@abadams
Copy link
Member

abadams commented Jun 26, 2023

Looks like this was removed in https://reviews.llvm.org/D153679

It's not clear to me how to get the same functionality though. LLVM seems to be going through and deleting a bunch of legacy pass manager stuff, which might make our life difficult in the very near future.

@abadams
Copy link
Member

abadams commented Jun 26, 2023

From the comment a few lines above:

"so don't worry about this 'legacy' tag until there's any indication that the old APIs start breaking."

Looks like the old APIs have started breaking.

@steven-johnson
Copy link
Contributor Author

Looks like the old APIs have started breaking.

Did you comment on the LLVM review page? If not, let's both do so, to make sure we get looped in as this changes.

@abadams
Copy link
Member

abadams commented Jun 26, 2023

Looks like the symbol rewriting pass was added in:

09d8c2e

It's an old commit. Hard to say if anyone is using the feature that this PR removes. Approving to unbreak the build, but it would be good to leave a TODO in the code to reenable the feature when we switch to the new pass manager.

@steven-johnson steven-johnson merged commit c28a00f into main Jun 26, 2023
@steven-johnson steven-johnson deleted the srj/llvm-output-fix branch June 26, 2023 20:10
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants