Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct inaccurate descriptions in the extended feed doc #42

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: correct inaccurate descriptions in the extended feed doc #42

merged 1 commit into from
Dec 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 5, 2024 •
edited
Loading

What this PR does?

移除监听 ContextClosedEvent 来清理 RSS 缓存的描述

如果插件 A 监听这个事件来清理 rss 缓存，那么当 feed 更新时会导致插件 A 发生以下错误只能重启 Halo 才能恢复

java.lang.reflect.UndeclaredThrowableException: Failed to invoke event listener method
HandlerMethod details: 
Bean [run.halo.moments.rss.RssAutoConfiguration$$SpringCGLIB$$0]
Method [public void run.halo.moments.rss.RssAutoConfiguration.onMomentUpdatedOrDeleted()]
Resolved arguments: 
of class "run/halo/feed/RssCacheClearRequested" have different types for the method signature
None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and ruibaby December 5, 2024 09:44
@guqing guqing marked this pull request as ready for review December 5, 2024 09:44
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen December 5, 2024 09:44
ruibaby
ruibaby approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 43c3955 into main Dec 5, 2024
2 checks passed
@guqing guqing deleted the chore/update-readme branch January 3, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guqing @ruibaby