Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change rss response encoding from us-ascii to utf8 #50

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 16, 2024

What this PR does?

为了与广泛使用的网络浏览器兼容将 RSS 的 Content Type 从 text/xml 改为 application/xml

当 RSS 作为 `application/xml 提供时,编码将从文件的声明中获取也就能保持是 utf8 而不会被误认为是 US-ASCII

参考:https://www.rssboard.org/rss-validator/docs/warning/EncodingMismatch.html

为了与广泛使用的网络浏览器兼容将 RSS 的 Content Type 从 `text/xml` 改为 `application/xml`

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby December 16, 2024 09:16
Copy link

f2c-ci-robot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing guqing merged commit 0b0f3f6 into main Dec 16, 2024
1 of 2 checks passed
@guqing guqing deleted the fix/xml branch December 16, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant