Optimize SortedSet#filter for speed

issue #136
hamstergem · Nov 5, 2014 · 45fca20 · 45fca20
1 parent ecd0602
commit 45fca20
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/hamster/sorted_set.rb b/lib/hamster/sorted_set.rb
@@ -308,7 +308,9 @@ def max
     # @return [SortedSet]
     def filter
       return enum_for(:filter) unless block_given?
-      reduce(self) { |set, item| yield(item) ? set : set.delete(item) }
+      items_to_delete = []
+      each { |item| items_to_delete << item unless yield(item) }
+      derive_new_sorted_set(@node.bulk_delete(items_to_delete, @comparator))
     end
 
     # Invoke the given block once for each item in the set, and return a new