Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Profile 영역 동적 렌더링 #34 #35

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

minsoo-web
Copy link
Member

Overview

Profile 영역을 layout 으로 처리할 수 있도록 작업하고, username 에 맞는 상수값을 선언해서 mapping 해줍니다.

Closes #

@minsoo-web minsoo-web requested a review from sonsurim as a code owner July 31, 2024 17:00
@minsoo-web minsoo-web linked an issue Jul 31, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
activity.hamsurang.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 6:22pm
hamsurang.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 6:22pm
home.hamsurang.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 6:22pm

@sonsurim
Copy link
Member

sonsurim commented Aug 1, 2024

@minsoo-webhome.hamsurang.com preview가 깨지는데 확인해주실 수 있나요!? 😱

Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민수님 요거 #36 메인에 머지되고 pull 받아서 배포 정상적으로 동작하는 거 확인되면 바로 머지해도 될 것 같습니다!

미리 approve 해둘게요!

commit 7cc1c85
Author: Sonny <[email protected]>
Date:   Wed Aug 7 02:28:14 2024 +0900

    fix: vercel 배포 시 오류 해결 (#36)

    * add start script

    * include root directory

    * fix reference error of path on next config

    * move the readme files to the public directory

    * change read file to asynchronous

    * apply an encoding format

    * remove public from filePath

    * join with separate paths

    * add public setting of vercel

    * replace join to resolve

    * using outputFileTracingIncludes

    * check if it works well even if outputFileTracingIncludes is removed

    * check if it works well even if outputFileTracingIncludes is changed

    * Revert "check if it works well even if outputFileTracingIncludes is removed"

    This reverts commit ec6073b.

    * refine paths to include files

    * Update turbo.json

    Co-authored-by: Minsoo Kim <[email protected]>

    * revert file path

    * revert incorrect path correction

    ---------

    Co-authored-by: Minsoo Kim <[email protected]>
@minsoo-web minsoo-web deleted the 34-feat-profile branch August 6, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Profile 영역 동적 렌더링
2 participants