update csharp infra #397
Open
update csharp infra #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
commented
Jun 19, 2023
| # docker_volumns: | ||
| # - /tmp/.nuget/packages:/root/.nuget/packages | ||
| include: dotnet_preview | ||
| build: dotnet publish -c Release -r linux-x64 -f net7 --self-contained true -p:PublishSingleFile=true -o out # -p:PublishReadyToRun=true | ||
| build: dotnet publish -c Release -r linux-x64 -f net8 --self-contained true -p:PublishSingleFile=true -o out # -p:PublishReadyToRun=true |
There was a problem hiding this comment.
we could target net7 just as well, but bench\include\dotnet_preview\app.csproj targets net8 so I had to change one or the other.
danmoseley
commented
Jun 19, 2023
| @@ -3,4 +3,4 @@ | |||
| curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo tee /etc/apt/trusted.gpg.d/microsoft.asc | |||
| sudo apt-add-repository https://packages.microsoft.com/ubuntu/22.04/prod | |||
| sudo apt-get update | |||
| sudo apt-get install -y libmsquic zlib1g-dev | |||
| sudo apt-get install -y libmsquic zlib1g-dev clang | |||
There was a problem hiding this comment.
haven't validated this is sufficient to get nativeaot to build in the container. if necessary we can remove it from bench.yml for now as the other changes should be fine.
|
@hanabi1224 could you unblock the validation workflow maybe? no hurry though :) |
hanabi1224
force-pushed
the
main
branch
3 times, most recently
from
3fc55d3 to
d70acc7
Compare
danmoseley
commented
Jul 12, 2023
| @@ -73,10 +77,10 @@ environments: | |||
| compiler: dotnet | |||
| version: 7 | |||
There was a problem hiding this comment.
possibly this should be 8 too, but I guess it works.
|
The tests timed out after 5 hours but the log only showed a couple mins of run time... |
|
@hanabi1224 I think it needs your okay again. |
|
@hanabi1224 ? 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable numbers for preview and nativeaot
change preview to actually use preview docker image
add necessary nativeaot dependency to image (clang)
minor readme updates
uncomment scenarios for preview
add multiproc versions of regex-redux so we get both sets of numbers
Note: I haven't got bench.yml to work locally so I haven't verified that clang is all that's needed for nativeaot.