respond with servfail if bogus #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an NSEC record to indicate that we only have NS NSEC RRSIG. This proves that we don't have a DS rr and allows unbound to treat the zone as unsigned.
buffrr
changed the title
|
Closed by #76 lets move discussion / review there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating DNSSEC, the resolver should return SERVFAIL if DNSSEC validation fails (bogus = true)
example:
dig @1.1.1.1 dnssec-failed.org awill return SERVFAIL
hnsd only omits the ad flag from the response which makes downgrade attacks possible.
Note: hnsd also considers handshake tlds without a DS RR bogus (they are not secure but they are also not bogus). This should also be fixed because this PR will break handshake tlds that don't use DNSSEC.Fixed by adding an NSEC record to prove that a DS doesn't exist which allows unbound to treat it as unsigned instead of bogus.