Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mortgage calculator demo error Cannot load native addon because loading addons is disabled #1486

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jan 15, 2025

Context

  • open demo in StackBlitz env instead of CodeSandbox
  • change the demo runner from parcel to vite

How did you test your changes?

check that the new link in the readme works

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Bug]: Mortgage demo in readme does not work #1480

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

Copy link

github-actions bot commented Jan 15, 2025

Performance comparison of head (81e1dd5) vs base (94dd0db)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 515.36 | 517.05 | +0.33%
                                      Sheet B | 169.99 | 168.11 | -1.11%
                                      Sheet T | 146.51 | 148.89 | +1.62%
                                Column ranges | 519.35 |  518.2 | -0.22%
Sheet A:  change value, add/remove row/column |  14.88 |   14.5 | -2.55%
 Sheet B: change value, add/remove row/column | 140.74 | 132.86 | -5.60%
                   Column ranges - add column |  156.2 | 158.86 | +1.70%
                Column ranges - without batch | 457.36 | 456.81 | -0.12%
                        Column ranges - batch | 117.66 |  114.5 | -2.69%

@sequba sequba self-assigned this Jan 15, 2025
@sequba sequba linked an issue Jan 15, 2025 that may be closed by this pull request
@sequba sequba marked this pull request as ready for review January 15, 2025 15:04
@sequba sequba requested a review from budnix January 15, 2025 15:07
@sequba sequba merged commit f392eae into develop Jan 15, 2025
24 checks passed
@sequba sequba deleted the feature/issue-1480 branch January 15, 2025 15:10
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (94dd0db) to head (81e1dd5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1486   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3080     3080           
========================================
  Hits         14120    14120           
  Misses         403      403           

sequba added a commit that referenced this pull request Jan 15, 2025
… (#1487)

* Fix registerLanguage() issue in the code examples (#1484)

Make code examples check for registered languages before registering new ones

* Fix mortgage calculator demo error `Cannot load native addon because loading addons is disabled` (#1486)

Migrate mortgage-calculator demo in readme from Codestandbox to Stackblitz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mortgage demo in readme does not work
2 participants