fix bugs in TypeScript code, add missing dependency and updater workflow #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, Thanks for your help. I will take a look and a test this week. Because I am quite busy recently. Actually I merged some helper scripts from my other repository to improve this extension. And I am gonna to optimize the parser related code in the next version. |
|
Thanks 👍🏼 I highly appreciate your quick response and positive feedback |
AdrianDsg
force-pushed
the
adriandsg-enhance-contents
branch
from
7ebb676
to
a210fdb
Compare
hangxingliu
requested changes
Apr 25, 2024
…ested in code review
hangxingliu
approved these changes
Apr 25, 2024
|
@AdrianDsg Sorry for waiting so long time, I was quite busy for working and personal things recently. Thanks for your help so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hangxingliu,
I noticed you been working on a refactoring of the TypeScript code (of the downloaders) recently.
I really like the new structure it's so much easier to understand for me.
I tested the new code and noticed that the (dev) dependency
turndown-plugin-gfmwas apparently missing. So I added that one.I also removed some of the code that I unfortunately forgot to remove after my last debugging session in #90.
I then created a GitHub Actions workflow to ease the updating of the JSON assets.
It would run on the first day of the month and open a pull request with the changes.
Please see AdrianDsg#2 for an example. It's just an idea of mine to support you and the project.