Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch calculate_size_of_first which is creating issues with embedded sets #204

Merged
merged 1 commit into from
Jul 17, 2021
Merged

patch calculate_size_of_first which is creating issues with embedded sets #204

merged 1 commit into from
Jul 17, 2021

Conversation

Andersama
Copy link
Contributor

@Andersama Andersama commented Jul 16, 2021 •
edited
Loading

Should solve #199 and #175

Issue stems from ctre::word_chars being a set*, when processed as part of the regex the current method massively undercounts the needed capacity.

@hanickadot hanickadot merged commit 95afdd8 into hanickadot:main Jul 17, 2021
@hanickadot
Copy link
Owner

Thanks! ❤️

@Andersama
Copy link
Contributor Author

I just realized, this likely solves sporadic issues where I couldn't compile expressions for #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andersama @hanickadot