Fix all regressions

src/main/java/at/hannibal2/skyhanni/config/core/elements/GuiElement.kt

@@ -2,6 +2,7 @@ package at.hannibal2.skyhanni.config.core.elements
 
 import net.minecraft.client.gui.Gui
 
+@Suppress("EmptyFunctionBlock", "UnusedParameter")
 abstract class GuiElement : Gui() {
     abstract fun render(x: Int, y: Int)
 

src/main/java/at/hannibal2/skyhanni/data/EntityMovementData.kt

@@ -4,8 +4,8 @@ import at.hannibal2.skyhanni.events.EntityMoveEvent
 import at.hannibal2.skyhanni.events.IslandChangeEvent
 import at.hannibal2.skyhanni.events.LorenzChatEvent
 import at.hannibal2.skyhanni.events.LorenzTickEvent
-import at.hannibal2.skyhanni.events.SkyHanniWarpEvent
 import at.hannibal2.skyhanni.events.LorenzWorldChangeEvent
+import at.hannibal2.skyhanni.events.SkyHanniWarpEvent
 import at.hannibal2.skyhanni.skyhannimodule.SkyHanniModule
 import at.hannibal2.skyhanni.utils.DelayedRun
 import at.hannibal2.skyhanni.utils.LorenzUtils

src/main/java/at/hannibal2/skyhanni/data/repo/RepoManager.kt

@@ -61,11 +61,12 @@ class RepoManager(private val configLocation: File) {
             return "${config.location.user}/${config.location.name}/${config.location.branch}"
         }
 
-        private val defaultUser = "hannibal002"
-        private val defaultName = "SkyHanni-REPO"
-        private val defaultBranch = "main"
+        private const val DEFAULT_USER = "hannibal002"
+        private const val DEFAULT_NAME = "SkyHanni-REPO"
+        private const val DEFAULT_BRANCH = "main"
 
-        fun RepositoryConfig.RepositoryLocation.hasDefaultSettings() = user == defaultUser && name == defaultName && branch == defaultBranch
+        fun RepositoryConfig.RepositoryLocation.hasDefaultSettings() =
+            user == DEFAULT_USER && name == DEFAULT_NAME && branch == DEFAULT_BRANCH
     }
 
     fun loadRepoInformation() {
@@ -246,7 +247,7 @@ class RepoManager(private val configLocation: File) {
                         ).asComponent(),
                 )
                 text.add("§7Repo Auto Update Value: §c${config.repoAutoUpdate}".asComponent())
-                text.add("§7Backup Repo Value: §c${usingBackupRepo}".asComponent())
+                text.add("§7Backup Repo Value: §c$usingBackupRepo".asComponent())
                 text.add("§7If you have Repo Auto Update turned off, please try turning that on.".asComponent())
                 text.add("§cUnsuccessful Constants §7(${unsuccessfulConstants.size}):".asComponent())
 
@@ -333,9 +334,9 @@ class RepoManager(private val configLocation: File) {
                 return
             }
 
-            user = defaultUser
-            name = defaultName
-            branch = defaultBranch
+            user = DEFAULT_USER
+            name = DEFAULT_NAME
+            branch = DEFAULT_BRANCH
             if (manual) {
                 ChatUtils.clickableChat(
                     "Reset Repo settings to default. " +

src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityRabbitTheFishChecker.kt

@@ -20,7 +20,7 @@ import org.lwjgl.input.Keyboard
 @SkyHanniModule
 object HoppityRabbitTheFishChecker {
 
-    //<editor-fold desc="Patterns">
+    // <editor-fold desc="Patterns">
     /**
      * REGEX-TEST: Chocolate Breakfast Egg
      * REGEX-TEST: Chocolate Lunch Egg
@@ -46,7 +46,7 @@ object HoppityRabbitTheFishChecker {
         "inventory.mealegg.continue",
         "(?:§.)*Click to open Chocolate Factory!",
     )
-    //</editor-fold>
+    // </editor-fold>
 
     private val config get() = SkyHanniMod.feature.event.hoppityEggs
     private var rabbitTheFishIndex: Int? = null

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/CustomScoreboardUtils.kt

@@ -4,8 +4,8 @@ import at.hannibal2.skyhanni.config.features.gui.customscoreboard.DisplayConfig
 import at.hannibal2.skyhanni.data.BitsAPI
 import at.hannibal2.skyhanni.data.HypixelData
 import at.hannibal2.skyhanni.data.PurseAPI
-import at.hannibal2.skyhanni.data.model.TabWidget
 import at.hannibal2.skyhanni.data.ScoreboardData
+import at.hannibal2.skyhanni.data.model.TabWidget
 import at.hannibal2.skyhanni.features.bingo.BingoAPI
 import at.hannibal2.skyhanni.features.gui.customscoreboard.CustomScoreboard.displayConfig
 import at.hannibal2.skyhanni.features.gui.customscoreboard.ScoreboardLine.Companion.align
@@ -18,6 +18,7 @@ import at.hannibal2.skyhanni.utils.StringUtils.removeResets
 import at.hannibal2.skyhanni.utils.StringUtils.trimWhiteSpace
 import java.util.regex.Pattern
 
+@Suppress("TooManyFunctions")
 object CustomScoreboardUtils {
 
     private fun getGroup(pattern: Pattern, list: List<String>, group: String) =
@@ -50,7 +51,7 @@ object CustomScoreboardUtils {
     internal fun getPurseEarned() = getGroup(PurseAPI.coinsPattern, getSbLines(), "earned")?.let { " §7(§e+$it§7)§6" }
 
     internal fun getBank() = TabWidget.BANK.matchMatcherFirstLine {
-        group("amount") + (groupOrNull("personal")?.let { " §7/ §6$it" } ?: "")
+        group("amount") + (groupOrNull("personal")?.let { " §7/ §6$it" }.orEmpty())
     } ?: "0"
 
     internal fun getBits() = formatNumber(BitsAPI.bits.coerceAtLeast(0))
@@ -69,7 +70,7 @@ object CustomScoreboardUtils {
 
     internal fun getNorthStars() = getGroup(ScoreboardPattern.northstarsPattern, getSbLines(), "northStars") ?: "0"
 
-    internal fun getTimeSymbol() = getGroup(ScoreboardPattern.timePattern, getSbLines(), "symbol") ?: ""
+    internal fun getTimeSymbol() = getGroup(ScoreboardPattern.timePattern, getSbLines(), "symbol").orEmpty()
 
     internal fun getTablistEvent() = TabWidget.EVENT.matchMatcherFirstLine { groupOrNull("color") + group("event") }
 

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/ScoreboardConfigEventElement.kt

@@ -1,5 +1,6 @@
 package at.hannibal2.skyhanni.features.gui.customscoreboard
 
+import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEvent
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventActiveTablist
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventAnniversary
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventBroodmother
@@ -20,7 +21,6 @@ import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEven
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventQueue
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventRedstone
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventRift
-import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEvent
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventServerClose
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventSpooky
 import at.hannibal2.skyhanni.features.gui.customscoreboard.events.ScoreboardEventStartingSoonTablist

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/ScoreboardPattern.kt

@@ -20,7 +20,7 @@ object ScoreboardPattern {
     // Main scoreboard
     private val mainSb = scoreboardGroup.group("main")
 
-    //TODO add regex tests
+    // TODO add regex tests
     val motesPattern by mainSb.pattern(
         "motes",
         "(?:§.)*Motes: (?:§.)*(?<motes>[\\d,]+).*",

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/elements/ScoreboardElementBits.kt

@@ -5,7 +5,6 @@ import at.hannibal2.skyhanni.data.HypixelData
 import at.hannibal2.skyhanni.data.IslandType
 import at.hannibal2.skyhanni.features.gui.customscoreboard.CustomScoreboard.displayConfig
 import at.hannibal2.skyhanni.features.gui.customscoreboard.CustomScoreboard.informationFilteringConfig
-import at.hannibal2.skyhanni.features.gui.customscoreboard.CustomScoreboardUtils.formatNumber
 import at.hannibal2.skyhanni.features.gui.customscoreboard.CustomScoreboardUtils.getBitsLine
 import at.hannibal2.skyhanni.utils.LorenzUtils.inAnyIsland
 

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/elements/ScoreboardElementCopper.kt

@@ -24,4 +24,4 @@ object ScoreboardElementCopper : ScoreboardElement() {
     override fun showIsland() = GardenAPI.inGarden()
 }
 
-// click: warp barn? 
+// click: warp barn?

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/elements/ScoreboardElementLobbyCode.kt

@@ -8,7 +8,7 @@ import at.hannibal2.skyhanni.features.dungeon.DungeonAPI
 object ScoreboardElementLobbyCode : ScoreboardElement() {
     override fun getDisplay(): String? {
         val lobbyCode = HypixelData.serverId ?: return null
-        val roomId = DungeonAPI.getRoomID()?.let { " §8$it" } ?: ""
+        val roomId = DungeonAPI.getRoomID()?.let { " §8$it" }.orEmpty()
         return "§8$lobbyCode$roomId"
     }
 

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/elements/ScoreboardElementPurse.kt

@@ -14,7 +14,7 @@ object ScoreboardElementPurse : ScoreboardElement() {
         var purse = formatNumber(PurseAPI.currentPurse)
 
         if (!displayConfig.hideCoinsDifference) {
-            purse += getPurseEarned() ?: ""
+            purse += getPurseEarned().orEmpty()
         }
 
         return when {

src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/elements/ScoreboardElementQuiver.kt

@@ -24,7 +24,8 @@ object ScoreboardElementQuiver : ScoreboardElement() {
                     QuiverAPI.currentAmount.toLong(),
                     QuiverAPI.MAX_ARROW_AMOUNT.toLong(),
                 ).getChatColor()
-            } else "") +
+            } else ""
+            ) +
             if (QuiverAPI.wearingSkeletonMasterChestplate) "∞"
             else {
                 when (arrowConfig.arrowAmountDisplay) {

src/main/java/at/hannibal2/skyhanni/features/mining/TunnelsMaps.kt

@@ -17,8 +17,8 @@ import at.hannibal2.skyhanni.events.LorenzKeyPressEvent
 import at.hannibal2.skyhanni.events.LorenzRenderWorldEvent
 import at.hannibal2.skyhanni.events.LorenzTickEvent
 import at.hannibal2.skyhanni.events.LorenzToolTipEvent
-import at.hannibal2.skyhanni.events.SkyHanniWarpEvent
 import at.hannibal2.skyhanni.events.RepositoryReloadEvent
+import at.hannibal2.skyhanni.events.SkyHanniWarpEvent
 import at.hannibal2.skyhanni.skyhannimodule.SkyHanniModule
 import at.hannibal2.skyhanni.test.command.ErrorManager
 import at.hannibal2.skyhanni.utils.CollectionUtils.addString

src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValueCalculator.kt

@@ -731,6 +731,7 @@ object EstimatedItemValueCalculator {
 
         // todo use repo
         val tieredEnchants = listOf("compact", "cultivating", "champion", "expertise", "hecatomb", "toxophilite")
+        @Suppress("PropertyWrapping")
         val onlyTierOnePrices = listOf("ultimate_chimera", "ultimate_fatal_tempo", "smoldering", "ultimate_flash", "divine_gift")
         val onlyTierFivePrices = listOf("ferocious_mana", "hardened_mana", "mana_vampire", "strong_mana")
 

src/main/java/at/hannibal2/skyhanni/utils/HypixelCommands.kt

@@ -161,7 +161,7 @@ object HypixelCommands {
     fun bank() {
         send("bank")
     }
-    
+
     fun pickupStash() {
         send("pickupstash")
     }

src/main/java/at/hannibal2/skyhanni/utils/StringUtils.kt

@@ -5,7 +5,6 @@ import at.hannibal2.skyhanni.data.hypixel.chat.event.SystemMessageEvent
 import at.hannibal2.skyhanni.mixins.transformers.AccessorChatComponentText
 import at.hannibal2.skyhanni.utils.GuiRenderUtils.darkenColor
 import at.hannibal2.skyhanni.utils.NumberUtil.addSeparators
-import at.hannibal2.skyhanni.utils.RegexUtils.matches
 import at.hannibal2.skyhanni.utils.RegexUtils.findAll
 import at.hannibal2.skyhanni.utils.RegexUtils.matches
 import net.minecraft.client.Minecraft

src/main/java/at/hannibal2/skyhanni/utils/TimeLimitedSet.kt

@@ -8,7 +8,11 @@ class TimeLimitedSet<T : Any>(
     private val removalListener: (T, RemovalCause) -> Unit = { _, _ -> },
 ) : Iterable<T> {
 
-    private val cache = TimeLimitedCache<T, Unit>(expireAfterWrite) { key, _, cause -> key?.let { removalListener(it, cause) } }
+    private val cache = TimeLimitedCache<T, Unit>(expireAfterWrite) { key, _, cause ->
+        key?.let {
+            removalListener(it, cause)
+        }
+    }
 
     fun add(element: T) {
         cache[element] = Unit