Improvement: Jacob's Contest Numbers on Custom Scoreboard #2452
Conversation
There was a problem hiding this comment.
The logic belongs into farming contest API.
Why is the existing pattern for detecting the scoreboard lines not sufficient? Aren't we already showing all contest lines in the custom scoreboard? This feels like code duplication to me right now. I'm sure I'm missing something, please elaborate.
This directly adds onto the Jacobs Event Entry. We detect the Jacobs lines using .nextAfter(), not patterns. There is no code duplication on the Scoreboard End |
As noted, this is new functionality to the custom scoreboard - it was using .nextAfter() to pull event data lines, meaning the formatting of numbers did not adhere to the custom scoreboard setting that affects things like bank, purse, copper, bits, etc. So I'd second the challenge that this is duplicated code |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
Closing this since Hypixel copied my PR on Alpha
|
What
Formats numbers relating to Jacob's contest with the user selected number format for the Custom Scoreboard.
Images
Old:
New:
Changelog Improvements