Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check line of sight before alerting about rare sea creature #2457

Closed
wants to merge 1 commit into from

Conversation

qtlunya
Copy link
Contributor

@qtlunya qtlunya commented Sep 4, 2024

What

Fixed missing canBeSeen check in rare sea creature alert.

Changelog Fixes

  • Fixed rare sea creature alert not checking if the sea creature can be seen by the player. - Luna

@github-actions github-actions bot added the Bug Fix Bug fixes label Sep 4, 2024
@hannibal002
Copy link
Owner

hannibal002 commented Sep 4, 2024

This Logic change will cause sea creatures not getting detected by the alert feature at all. Even then, when the mob spawns behind blocks and gets pulled into the player's line of sight a second later.

I think there is a "SkyBlock Mob first time see event" or something especially for this
This Event does not exist, we need a new event for this since this very behavior is needed in multiple features. see 3cd3958

@hannibal002 hannibal002 added this to the Version 0.27 milestone Sep 4, 2024
@ItsEmpa
Copy link
Contributor

ItsEmpa commented Sep 4, 2024

This Logic change will cause sea creatures entirely not getting enounced by the alert feature, even when they Spawn behind blocks and get pulled into the player's line of sight a second later.
I think there is a "skyblock Mob first time see event" or something especially for this

that event doesnt mean first time you ACTUALLY see the mob, its just the first time that mob is detected

@hannibal002
Copy link
Owner

that event doesnt mean first time you ACTUALLY see the mob, its just the first time that mob is detected

I'm talking about this

image

The mob spawn even already handles "first detection". otherwise, the names would be horrible wrong or the spawn event would fire multiple times for the same entity, right?

@qtlunya qtlunya marked this pull request as draft September 4, 2024 09:31
@hannibal002 hannibal002 removed the Bug Fix Bug fixes label Sep 10, 2024
@hannibal002 hannibal002 removed this from the Version 0.27 milestone Sep 20, 2024
@qtlunya qtlunya closed this Oct 11, 2024
@qtlunya qtlunya deleted the rare-sc-los-check branch October 11, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants