-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Flowstate helper #2561
Feature: Flowstate helper #2561
Conversation
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…e-bro # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningConfig.java
Conflicts have been resolved! 🎉 |
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few things i saw (didnt test)
also could you call the hasFlowstate function on item change and then cache that value as flowstateCache instead of also having the hasChangedItem variable
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested in game yet.
Just a bunch of code cleanup suggestions. If you need help with anything please ask
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine apart from this enum name
src/main/java/at/hannibal2/skyhanni/features/mining/FlowstateHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…e-bro # Conflicts: # src/main/java/at/hannibal2/skyhanni/config/features/mining/MiningConfig.java
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
Couple sugestions:
Show flowstate display even when not holding a mining tool in hand, while the time is still remaining. maybe make it an option (default enabled)
the "auto hide" option doesnt seem to work, also i dont think this is necessary as an seting. simply hide after the 10 seconds are over.
change the color of the time to blue, for consistency over the whole mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The display disappears after reaching 200 streaks, even when still actively mining.
this is intended, in my opinion there isn't much of a point to keep showing it when it has no more useful info |
but i wanna see funny number go up |
What
adds a status gui with the current state of the flowstate enchantment bonus
Images
Changelog New Features