Backend: Detekt Fixes Part 5 #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
reviewed
Sep 29, 2024
src/main/java/at/hannibal2/skyhanni/features/rift/area/dreadfarm/VoltHighlighter.kt
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
CalMWolfs
approved these changes
Oct 2, 2024
hannibal002
added
the
Soon
github-actions
bot
removed
the
Soon
Tryp0xd
pushed a commit
to Tryp0xd/SkyHanni
that referenced
this pull request
Oct 3, 2024
* Version 0.27 Beta 13 * Feature: West Village/Dreadfarm/Living Cave features (hannibal002#2616) Co-authored-by: hannibal2 <[email protected]> * Fix: Jasper Gemstones not in Powder Mining Filter (hannibal002#2618) * changed todo * added parameter `/shcopylocation pathfind` * Fix a massive bug (hannibal002#2626) * Fix: Typos in readme (hannibal002#2629) * Fix: Custom Scoreboard Carnival (hannibal002#2631) * formatting * Fix: Add more Pablo patterns (hannibal002#2636) * Fix: Minister in Calendar Color Reset (hannibal002#2632) * Fix: Strays Wrongly Counting as Unique (hannibal002#2627) * Fix: Item trackers saying removed item name from item name (hannibal002#2620) * fix time format showing empty string for sub 1s * fixed composter data collection * Improvement: Add ignored crops for lane features (hannibal002#2622) * Improvement: Change "efficient miner" to "spread" in mineshaft pity breakdown (hannibal002#2633) * Backend: Rename keystore file to specify it is for skyhanni (hannibal002#2619) * Fix: Superpair Data (hannibal002#2566) Co-authored-by: hannibal2 <[email protected]> Co-authored-by: CalMWolfs <[email protected]> * Improvement: Added cooldown to Carnival NPC click (hannibal002#2628) * Automatically stating pathfind after clicking the hypixel reminder ch… (hannibal002#2635) Co-authored-by: hannibal2 <[email protected]> * Improvement: Pathfind Rendering (hannibal002#2634) Co-authored-by: hannibal2 <[email protected]> * Backend: Alert Clock Offsets (hannibal002#2623) Co-authored-by: hannibal2 <[email protected]> Co-authored-by: CalMWolfs <[email protected]> * fixed typo in broodmother message * fixed errors when path is zero * Version 0.27 Beta 14 * Improvement: Slight Touch up for Hoppity Event Summary (hannibal002#2638) * code cleanup * Fix: Highlight in Bazaar (hannibal002#2640) Co-authored-by: hannibal2 <[email protected]> * Fix: Flare expire warning (hannibal002#2643) Co-authored-by: hannibal2 <[email protected]> * Fix: Ender node tracker (hannibal002#2644) Co-authored-by: hannibal2 <[email protected]> * Fix: Powder Tracker not tracking items (hannibal002#2645) * Fix: Preconditions to debug commands (hannibal002#2641) Co-authored-by: hannibal2 <[email protected]> Co-authored-by: CalMWolfs <[email protected]> * Fix: Dummies and Damage Indicator (hannibal002#2646) Co-authored-by: hannibal2 <[email protected]> * fixed wrong feature toggle * Improvement: Superpair Experimentation data always visible (hannibal002#2647) Co-authored-by: hannibal2 <[email protected]> Co-authored-by: CalMWolfs <[email protected]> * Backend: Detekt Fixes Part 5 (hannibal002#2617) --------- Co-authored-by: hannibal2 <[email protected]> Co-authored-by: MTOnline69 <[email protected]> Co-authored-by: David Cole <[email protected]> Co-authored-by: CalMWolfs <[email protected]> Co-authored-by: J10a1n15 <[email protected]> Co-authored-by: Luna <[email protected]> Co-authored-by: martimavocado <[email protected]> Co-authored-by: ILike2WatchMemes <[email protected]> Co-authored-by: minhperry <[email protected]> Co-authored-by: hannibal2 <[email protected]> Co-authored-by: CalMWolfs <[email protected]> Co-authored-by: HiZe <[email protected]> Co-authored-by: ItsEmpa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes all instances of the following detektions:
ModifierListSpacingNoMultipleSpacesNoSemicolonsNoTrailingSpacesPropertyWrappingSpacingAroundCommaSpacingAroundCurlySpacingAroundOperatorsUnnecessaryParenthesesBeforeTrailingLambdaDetektion count down to 630 from 719 at HEAD.
exclude_from_changelog