Feature: Show unique hoppity eggs in the warp menu #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j10a1n15
reviewed
Sep 30, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/WarpMenuUniques.kt
Outdated
Show resolved
Hide resolved
|
Please add the information what you collect here as well. Otherwise it's pretty hard to find what mod or what feature that is when someone just searches for "collected" in configs. Also an option to hide when maxed would be nice |
should a dropdown in the config, now that we would have multiple toggles for the same feature |
Please avoid using drop downs for enable/disable options that way. They don't have a default "disable everything" state |
CalMWolfs
approved these changes
Oct 8, 2024
jani270
added
the
Soon
hannibal002
requested changes
Oct 8, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/WarpMenuUniques.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/WarpMenuUniques.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/WarpMenuUniques.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/WarpMenuUniques.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/hoppity/HoppityEggsConfig.java
Outdated
Show resolved
Hide resolved
|
Also please edit the changelog so that it is clean what the feature does, now what you can do with it. |
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
adds a way to quickly check every island for missing hoppity eggs
Images
it looks like this now
Changelog New Features