Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add Suggestion Provider and guild support in tab complete #2637

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

ThatGravyBoat
Copy link
Contributor

@ThatGravyBoat ThatGravyBoat commented Oct 1, 2024

What

Adds suggestion provider to create suggestion trees to suggest appropriate arguments for commands.

Changelog Improvements

  • Added support for Guilds in player-related tab completions. - ThatGravyBoat
  • Added support for all Guild and Friend commands in tab completions. - ThatGravyBoat

Changelog Technical Details

  • Added SuggestionProvider. - ThatGravyBoat
    • This new class simplifies building suggestion trees.

@hannibal002 hannibal002 added this to the Version 0.27 milestone Oct 1, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 1, 2024
@ThatGravyBoat ThatGravyBoat marked this pull request as draft October 2, 2024 11:43
@ThatGravyBoat ThatGravyBoat changed the title Improvement: Add guild support to tab complete Improvement: Add Suggestion Provider and guild support in tab complete Oct 2, 2024
@ThatGravyBoat ThatGravyBoat marked this pull request as ready for review October 2, 2024 13:34
@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Oct 3, 2024
@hannibal002 hannibal002 added Soon This Pull Request will be merged within the next couple of betas and removed Soon This Pull Request will be merged within the next couple of betas labels Oct 3, 2024
@hannibal002 hannibal002 merged commit 2ebce56 into hannibal002:beta Oct 9, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants