Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Slight Touch up for Hoppity Event Summary #2638

Merged

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Oct 2, 2024

What

Fixed a formatting issue, and finally fixed the problem with the empty lines causing unnecessary spacing in the stats card.

Changelog Improvements

  • Improved the formatting of the Hoppity Event Stats card. - Daveed

Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

on another note the formatting in this should probably switch over to our Text thing as that has methods to center text and create the ----- dividers.

@hannibal002 hannibal002 added this to the Version 0.27 milestone Oct 2, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 2, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Text.createDivider()

@DavidArthurCole
Copy link
Contributor Author

Use Text.createDivider()

I can't without refactoring the method. It only supports color or bold, and not both. Also, not sure why we'd change that here rather than a month ago when this was first put into beta.

@hannibal002 hannibal002 merged commit b45002e into hannibal002:beta Oct 2, 2024
5 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 2, 2024
@DavidArthurCole DavidArthurCole deleted the HoppityEventSummaryFormatting branch October 2, 2024 17:11
Tryp0xd pushed a commit to Tryp0xd/SkyHanni that referenced this pull request Oct 3, 2024
* Version 0.27 Beta 13

* Feature: West Village/Dreadfarm/Living Cave features (hannibal002#2616)

Co-authored-by: hannibal2 <[email protected]>

* Fix: Jasper Gemstones not in Powder Mining Filter (hannibal002#2618)

* changed todo

* added parameter `/shcopylocation pathfind`

* Fix a massive bug (hannibal002#2626)

* Fix: Typos in readme (hannibal002#2629)

* Fix: Custom Scoreboard Carnival (hannibal002#2631)

* formatting

* Fix: Add more Pablo patterns (hannibal002#2636)

* Fix: Minister in Calendar Color Reset (hannibal002#2632)

* Fix: Strays Wrongly Counting as Unique (hannibal002#2627)

* Fix: Item trackers saying removed item name from item name (hannibal002#2620)

* fix time format showing empty string for sub 1s

* fixed composter data collection

* Improvement: Add ignored crops for lane features (hannibal002#2622)

* Improvement: Change "efficient miner" to "spread" in mineshaft pity breakdown (hannibal002#2633)

* Backend: Rename keystore file to specify it is for skyhanni (hannibal002#2619)

* Fix: Superpair Data (hannibal002#2566)

Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>

* Improvement: Added cooldown to Carnival NPC click (hannibal002#2628)

* Automatically stating pathfind after clicking the hypixel reminder ch… (hannibal002#2635)

Co-authored-by: hannibal2 <[email protected]>

* Improvement: Pathfind Rendering (hannibal002#2634)

Co-authored-by: hannibal2 <[email protected]>

* Backend: Alert Clock Offsets (hannibal002#2623)

Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>

* fixed typo in broodmother message

* fixed errors when path is zero

* Version 0.27 Beta 14

* Improvement: Slight Touch up for Hoppity Event Summary (hannibal002#2638)

* code cleanup

* Fix: Highlight in Bazaar (hannibal002#2640)

Co-authored-by: hannibal2 <[email protected]>

* Fix: Flare expire warning (hannibal002#2643)

Co-authored-by: hannibal2 <[email protected]>

* Fix: Ender node tracker (hannibal002#2644)

Co-authored-by: hannibal2 <[email protected]>

* Fix: Powder Tracker not tracking items (hannibal002#2645)

* Fix: Preconditions to debug commands (hannibal002#2641)

Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>

* Fix: Dummies and Damage Indicator (hannibal002#2646)

Co-authored-by: hannibal2 <[email protected]>

* fixed wrong feature toggle

* Improvement: Superpair Experimentation data always visible (hannibal002#2647)

Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>

* Backend: Detekt Fixes Part 5 (hannibal002#2617)

---------

Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: MTOnline69 <[email protected]>
Co-authored-by: David Cole <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>
Co-authored-by: J10a1n15 <[email protected]>
Co-authored-by: Luna <[email protected]>
Co-authored-by: martimavocado <[email protected]>
Co-authored-by: ILike2WatchMemes <[email protected]>
Co-authored-by: minhperry <[email protected]>
Co-authored-by: hannibal2 <[email protected]>
Co-authored-by: CalMWolfs <[email protected]>
Co-authored-by: HiZe <[email protected]>
Co-authored-by: ItsEmpa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants