Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Command Register Event #2642

Merged
merged 32 commits into from
Oct 13, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Oct 2, 2024

TODO @ hani

spin the order of commands around and change the names and categories
also improve the "changelog improvements"

What

This Pull Request is another step toward modern version support where creating commands is even based, instead of the the 1.8 way.
It reduces clutter by cleaning up Commands.kt and moving most commands in their own class where they are supposed to be (todo in a later pr?).
It also reduces the amount of merge conflicts in the main commands file (not a lot though)
Replaces #2421

Commands that got changed:

old -> new
shclearfarmingitems -> shresetfarmingitems
shclearslayerprofits -> shresetslayerprofits
shclearcropspeed -> shresetcropspeed
shclearkismet -> shresetkismet
shclearcontestdata -> shresetcontestdata
shclearsavedrabbits -> shresetsavedrabbits
shclearminiondata -> shfixminions

Changelog Improvements

  • Reordered commands in categories. - hannibal2
  • Renamed some commands for clarity. - hannibal2

Changelog Technical Details

  • Made command registration event-based. - j10a1n15, ThatGravyBoat

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 2, 2024
@j10a1n15 j10a1n15 marked this pull request as draft October 2, 2024 21:03
@j10a1n15 j10a1n15 marked this pull request as ready for review October 3, 2024 09:00
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me and looks exciting

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 11, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 11, 2024
Copy link

Conflicts have been resolved! 🎉

Signed-off-by: J10a1n15 <[email protected]>
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 11, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
Signed-off-by: J10a1n15 <[email protected]>
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 11, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 11, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

…ister-event

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: list of renamed commands: (old -> new)
Change should end with a full stop in text: list of renamed commands: (old -> new)
Change should start with a capital letter in text: shclearfarmingitems -> shresetfarmingitems
Change should end with a full stop in text: shclearfarmingitems -> shresetfarmingitems
Change should start with a capital letter in text: shclearslayerprofits -> shresetsayerprofits
Change should end with a full stop in text: shclearslayerprofits -> shresetsayerprofits
Change should start with a capital letter in text: shclearcropspeed -> shresetropspeed
Change should end with a full stop in text: shclearcropspeed -> shresetropspeed
Change should start with a capital letter in text: shclearkismet -> shresetkismet
Change should end with a full stop in text: shclearkismet -> shresetkismet
Change should start with a capital letter in text: shclearcontestdata -> shresetcontestdata
Change should end with a full stop in text: shclearcontestdata -> shresetcontestdata
Change should start with a capital letter in text: shclearsavedrabbits -> shresetsavedrabbits
Change should end with a full stop in text: shclearsavedrabbits -> shresetsavedrabbits
Change should start with a capital letter in text: shclearminiondata -> shfixminions
Change should end with a full stop in text: shclearminiondata -> shfixminions

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 13, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: list of renamed commands: (old -> new)
Change should end with a full stop in text: list of renamed commands: (old -> new)
Change should start with a capital letter in text: shclearfarmingitems -> shresetfarmingitems.
Change should start with a capital letter in text: shclearslayerprofits -> shresetsayerprofits.
Change should start with a capital letter in text: shclearcropspeed -> shresetropspeed.
Change should start with a capital letter in text: shclearkismet -> shresetkismet.
Change should start with a capital letter in text: shclearcontestdata -> shresetcontestdata.
Change should start with a capital letter in text: shclearsavedrabbits -> shresetsavedrabbits.
Change should start with a capital letter in text: shclearminiondata -> shfixminions.
Change should end with a full stop in text: shclearminiondata -> shfixminions.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 13, 2024
@hannibal002 hannibal002 merged commit 113389a into hannibal002:beta Oct 13, 2024
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Oct 13, 2024
@j10a1n15 j10a1n15 deleted the backend/command-register-event branch October 13, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants