Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hoppity Purse Blocker #2664

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

DavidArthurCole
Copy link
Contributor

What

Adds a blocker to prevent opening Hoppity's shop without coins.

Changelog New Features

  • Added a feature to block opening Hoppity's trade menu from Abiphone calls if you do not have coins in your purse. - Daveed

Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem in code (but I also don't understand why this exist or the description of the config is bad)

@DavidArthurCole
Copy link
Contributor Author

I don't see any problem in code (but I also don't understand why this exist or the description of the config is bad)

Once you open the hoppity call (i.e., click Yes), if you don't have coins, you lose out on the offer - so, block opening the call if you don't have coins. Not sure if the config needs updating.

@Thunderblade73
Copy link
Contributor

Yeah, that makes sense. But that isn't what the config reads to me. Since I thought it was about the normal hoppity shop, which didn't make sense.

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 13, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 13, 2024
@hannibal002 hannibal002 merged commit a33034e into hannibal002:beta Oct 16, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 16, 2024
@DavidArthurCole DavidArthurCole deleted the HoppityCoinBlocker branch October 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants