Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Working on scoreboard errors again #2672

Merged
merged 7 commits into from
Oct 6, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Oct 5, 2024

What

Partially reverting
#2411

can be tested with

patch
Index: src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt b/src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt
--- a/src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt(revision 6e5131e0941a72413ed7b3fd44ef352321cf03af)
+++ b/src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt(date 1728127634709)
@@ -2,6 +2,7 @@
 
 import at.hannibal2.skyhanni.data.BitsAPI
 import at.hannibal2.skyhanni.data.HypixelData
+import at.hannibal2.skyhanni.data.MiningAPI
 import at.hannibal2.skyhanni.data.PurseAPI
 import at.hannibal2.skyhanni.data.ScoreboardData
 import at.hannibal2.skyhanni.features.misc.ServerRestartTitle
@@ -14,6 +15,7 @@
 import at.hannibal2.skyhanni.utils.RegexUtils.matches
 import at.hannibal2.skyhanni.utils.SimpleTimeMark
 import at.hannibal2.skyhanni.utils.StringUtils.removeResets
+import at.hannibal2.skyhanni.utils.TimeUtils.format
 import java.util.regex.Pattern
 import kotlin.time.Duration.Companion.minutes
 import kotlin.time.Duration.Companion.seconds
@@ -140,7 +142,8 @@
     private var remoteOnlyPatternsAdded = false
 
     fun handleUnknownLines() {
-        val sidebarLines = ScoreboardData.sidebarLinesFormatted
+        val format = MiningAPI.lastColdUpdate.passedSince().format()
+        val sidebarLines = ScoreboardData.sidebarLinesFormatted + "format: $format"
 
         var unknownLines = sidebarLines.map { it.removeResets() }.filter { it.isNotBlank() }.filter { it.trim().length > 3 }
 

Changelog Improvements

  • Reduced the frequency of scoreboard errors being displayed. - hannibal2

Changelog Fixes

  • Fixed some scoreboard error messages appearing in chat. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 5, 2024
@hannibal002 hannibal002 added this to the Version 0.27 milestone Oct 5, 2024
@hannibal002 hannibal002 marked this pull request as ready for review October 5, 2024 11:14
@hannibal002 hannibal002 added the Bug Fix Bug fixes label Oct 5, 2024
@github-actions github-actions bot removed the Bug Fix Bug fixes label Oct 5, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

@hannibal002 hannibal002 merged commit df1bff9 into beta Oct 6, 2024
11 checks passed
@hannibal002 hannibal002 deleted the fix-scoreboard-again branch October 6, 2024 08:54
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants