Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Improvement: Translator feature #2693

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Obsidianninja11
Copy link
Contributor

What

Fixes this bug report - /shtranslate broke if the language code in the config was filled out (which it is by default)
Properly implements using the translator for languages other than English.
Rewrites a decent bit of the translator backend.

Probably still a bit more to do (it's kind of messy in its current state, and I might switch to the named json thing I put as a todo)

Changelog Fixes

  • Fixed /shtranslate not working in most cases. - Obsidian

Changelog Technical Details

  • Added /shtranslateadvanced command. - Obsidian
    • Allows specifying both the source and target language.

@Obsidianninja11 Obsidianninja11 changed the title Fix/Imrovement: Translator feature Fix/Improvement: Translator feature Oct 8, 2024
@github-actions github-actions bot added the Bug Fix Bug fixes label Oct 8, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Oct 8, 2024
@CalMWolfs CalMWolfs self-requested a review October 8, 2024 11:02
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 11, 2024
@hannibal002 hannibal002 merged commit 92291e6 into hannibal002:beta Oct 11, 2024
4 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Bug Fix Bug fixes labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants