Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: update moulconfig #2737

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from

Conversation

catgirlseraid
Copy link
Contributor

@catgirlseraid catgirlseraid commented Oct 14, 2024

What

updates moulconfig to fix some bugs. some of the prs are linked below, as well as a list of the ones i personally fixed.

also adds replaced search terms to allow for more consistant config searching in the future, which should allow users to find features easier.

NotEnoughUpdates/MoulConfig#29
NotEnoughUpdates/MoulConfig#30
NotEnoughUpdates/MoulConfig#31
NotEnoughUpdates/MoulConfig#33

Changed blue background on dropdown menu to white to better refect the rest of the colour scheme
Added tooltip when hovering over bin or reset keybind icon
Added mouse selection to text in a text box
Fixed description being off by a few pixels
Centered the icon next to dragable lists instead of it being aligned to the bottom
Fixed keybinds text sometimes overflowing buttons if the key name is too long
Fixed using up arrow keys in pages where scrolling shouldn't be possible causing the scroll bar to go out of bounds
Fixed not being able to hold down a key in text fields including backspace
Fix right click not clearing search bar
fixed text in search box not centering
fixed dragable list staying when scrolling
fixed title bar being off by one pixel
fixed not being able to escape from slider textbox
fixed draging option when requiring at least one option causing the option to become invisible
fixed hex code centering
fixed colour code menu still displaying when scrolling
fixed not being able to type in colour selector hex code
fixed esc while in colour selector closing the whole moulconfig
add ability to set search functions to editor

Changelog Technical Details

  • Updated moulconfig to fix some issues and improve searching. - phoebe

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 14, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Moulconfig update

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@catgirlseraid catgirlseraid changed the title update moulconfig Backend: update moulconfig Oct 14, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 14, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Moulconfig update

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 14, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for changing the resources around.

while testing, the replaced search terms dont work and if they are found, it removes them from the search entirely

image
image

Without adding the r
image

@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 14, 2024
@catgirlseraid
Copy link
Contributor Author

should be fixed now @CalMWolfs

… way around

thanks nea for the code <3
Co-authored-by: nea <[email protected]>
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Oct 16, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me 🥉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 16, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/update/GuiOptionEditorUpdateCheck.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 17, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added test and removed test labels Oct 18, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 18, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend A backend pull request that will be merged soon Merge Conflicts There are open merge conflicts with the beta branch. Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants