Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Replace lorenevent with skyhanni event #2750

Open
wants to merge 28 commits into
base: beta
Choose a base branch
from
Open

Backend: Replace lorenevent with skyhanni event #2750

wants to merge 28 commits into from

Conversation

NopoTheGamer
Copy link
Contributor

@NopoTheGamer NopoTheGamer commented Oct 17, 2024 •
edited by CalMWolfs
Loading

Dependencies

What

Gets rid of lorenzevent and uses skyhannievent on everything.
This is an important step of modern version support

Images

image

Changelog Technical Details

  • Replace LorenzEvent with SkyhanniEvent. - nopo & CalMWolfs
    • A few files got changed.

@NopoTheGamer NopoTheGamer changed the title Changes by Cal Backend: Replace lorenevent with skyhanni event Oct 17, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 17, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: few files got changed.

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 17, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: few files got changed.

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 17, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Oct 17, 2024
CalMWolfs
CalMWolfs approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Additionally, when this is merged I will go fix up all prs that this causes to not build or that get merge conflicts because of this

@hannibal002
Copy link
Owner

Too big of an pr. Please don't create that many lines changes at once in the future

@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Oct 17, 2024
@hannibal002
Copy link
Owner

Reopening this after heavy discussions and throwing arguments around on discord for couple hours.

@hannibal002 hannibal002 reopened this Oct 18, 2024
@jani270 jani270 added the Backend A backend pull request that will be merged soon label Oct 18, 2024
@CalMWolfs
Backend: Add in event handler check to SkyHanni Events
897cc79
@CalMWolfs
Merge branch 'refs/heads/in-event-handler' into events
e5be14c 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/ConfigManager.kt
#	src/main/java/at/hannibal2/skyhanni/utils/ConfigUtils.kt
#	src/main/java/at/hannibal2/skyhanni/utils/repopatterns/RepoPatternManager.kt
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 18, 2024
ItsEmpa
ItsEmpa reviewed Oct 18, 2024
View reviewed changes
src/main/java/at/hannibal2/skyhanni/features/misc/update/UpdateManager.kt
@SubscribeEvent
fun onTick(event: LorenzTickEvent) {
@HandleEvent
fun onTick(event: SkyHanniTickEvent) {
Minecraft.getMinecraft().thePlayer ?: return
MinecraftForge.EVENT_BUS.unregister(this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wont changing this to a SkyHanniEvent make it so that this doesnt get unregistered anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsEmpa ItsEmpa ItsEmpa left review comments

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon Merge Conflicts There are open merge conflicts with the beta branch.
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
5 participants
@NopoTheGamer @hannibal002 @ItsEmpa @CalMWolfs @jani270